fix(expo): set projectRoot to workspaceRoot for Expo SDK 54+ compatibility#33836
Merged
fix(expo): set projectRoot to workspaceRoot for Expo SDK 54+ compatibility#33836
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 8f7dfd1
☁️ Nx Cloud last updated this comment at |
…ility Expo CLI 54.0.12+ changed how originModulePath is determined in Metro resolvers - from workspace root to project root. This caused the Nx custom resolver to double-path modules when resolving workspace libraries. This fix: - Adds projectRoot: workspaceRoot to the Metro config to ensure originModulePath remains workspace-relative - Adds defensive path normalization in pnpmResolver to handle edge cases Fixes #33597
jaysoo
approved these changes
Dec 12, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 15, 2025
…ility (#33836) Expo CLI 54.0.12+ changed how originModulePath is determined in Metro resolvers - from workspace root to project root. This caused the Nx custom resolver to double-path modules when resolving workspace libraries. This fix: - Adds projectRoot: workspaceRoot to the Metro config to ensure originModulePath remains workspace-relative - Adds defensive path normalization in pnpmResolver to handle edge cases Fixes #33597
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expo CLI 54.0.12+ changed how originModulePath is determined in Metro
resolvers - from workspace root to project root. This caused the Nx
custom resolver to double-path modules when resolving workspace libraries.
This fix:
originModulePath remains workspace-relative
Fixes #33597