Skip to content

fix(js): make CopyAssetsHandler per-file logs opt-in via verbose mode#33835

Merged
Coly010 merged 1 commit intomasterfrom
fix/copy-assets-handler-logs
Dec 12, 2025
Merged

fix(js): make CopyAssetsHandler per-file logs opt-in via verbose mode#33835
Coly010 merged 1 commit intomasterfrom
fix/copy-assets-handler-logs

Conversation

@Coly010
Copy link
Copy Markdown
Contributor

@Coly010 Coly010 commented Dec 12, 2025

The CopyAssetsHandler was logging every copied file to the console,
causing noisy output when a project copies many files. This could
cause build errors to be cut off in terminals with scroll limits.

Change logger.log() to logger.verbose() so per-file logging only
appears when --verbose is passed or NX_VERBOSE_LOGGING=true.

Fixes #33521

The CopyAssetsHandler was logging every copied file to the console,
causing noisy output when a project copies many files. This could
cause build errors to be cut off in terminals with scroll limits.

Change logger.log() to logger.verbose() so per-file logging only
appears when --verbose is passed or NX_VERBOSE_LOGGING=true.

Fixes #33521
@Coly010 Coly010 requested a review from a team as a code owner December 12, 2025 11:51
@Coly010 Coly010 self-assigned this Dec 12, 2025
@Coly010 Coly010 requested a review from leosvelperez December 12, 2025 11:51
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Dec 12, 2025 11:58am

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 12, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 22ebbb2
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/693c01bc02c84e0008c5c305
😎 Deploy Preview https://deploy-preview-33835--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Dec 12, 2025

View your CI Pipeline Execution ↗ for commit 22ebbb2

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 33m 17s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 31s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 12s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-12 12:30:06 UTC

@Coly010 Coly010 merged commit e588a0e into master Dec 12, 2025
21 checks passed
@Coly010 Coly010 deleted the fix/copy-assets-handler-logs branch December 12, 2025 13:50
FrozenPandaz pushed a commit that referenced this pull request Dec 15, 2025
…#33835)

The CopyAssetsHandler was logging every copied file to the console,
causing noisy output when a project copies many files. This could
cause build errors to be cut off in terminals with scroll limits.

Change logger.log() to logger.verbose() so per-file logging only
appears when --verbose is passed or NX_VERBOSE_LOGGING=true.

Fixes #33521
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Noisy log output from CopyAssetsHandler

2 participants