Skip to content

fix(angular): collect known tsconfig files from non-buildable angular libraries in migration#33834

Merged
Coly010 merged 1 commit intomasterfrom
issue-33705
Dec 12, 2025
Merged

fix(angular): collect known tsconfig files from non-buildable angular libraries in migration#33834
Coly010 merged 1 commit intomasterfrom
issue-33705

Conversation

@leosvelperez
Copy link
Copy Markdown
Member

@leosvelperez leosvelperez commented Dec 12, 2025

Current Behavior

The update-21-2-0/update-module-resolution migration doesn't process any tsconfig files of non-buildable libraries.

Expected Behavior

The update-21-2-0/update-module-resolution migration should process common/known tsconfig files of non-buildable libraries.

Related Issue(s)

Fixes #33705

@leosvelperez leosvelperez self-assigned this Dec 12, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Dec 12, 2025 11:23am

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 12, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit bdceb6a
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/693bf9d6d3bfef0008fd200c
😎 Deploy Preview https://deploy-preview-33834--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Dec 12, 2025

View your CI Pipeline Execution ↗ for commit bdceb6a

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 8m 35s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 20s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 11s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-12 12:26:03 UTC

@leosvelperez leosvelperez marked this pull request as ready for review December 12, 2025 12:31
@leosvelperez leosvelperez requested a review from a team as a code owner December 12, 2025 12:31
@leosvelperez leosvelperez requested a review from jaysoo December 12, 2025 12:31
@Coly010 Coly010 merged commit f618935 into master Dec 12, 2025
22 of 23 checks passed
@Coly010 Coly010 deleted the issue-33705 branch December 12, 2025 17:50
FrozenPandaz pushed a commit that referenced this pull request Dec 15, 2025
… libraries in migration (#33834)

## Current Behavior

The `update-21-2-0/update-module-resolution migration` doesn't process
any tsconfig files of non-buildable libraries.

## Expected Behavior

The `update-21-2-0/update-module-resolution migration` should process
common/known tsconfig files of non-buildable libraries.

## Related Issue(s)

Fixes #33705

(cherry picked from commit f618935)
FrozenPandaz pushed a commit that referenced this pull request Dec 15, 2025
… libraries in migration (#33834)

## Current Behavior

The `update-21-2-0/update-module-resolution migration` doesn't process
any tsconfig files of non-buildable libraries.

## Expected Behavior

The `update-21-2-0/update-module-resolution migration` should process
common/known tsconfig files of non-buildable libraries.

## Related Issue(s)

Fixes #33705
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module resolution is not updated for tsconfigs not specified in a project.json file

2 participants