fix(storybook): conditionally include node imports only for non-angular frameworks#33728
Merged
Coly010 merged 2 commits intonrwl:masterfrom Dec 9, 2025
Merged
Conversation
…ar frameworks The fileURLToPath and dirname imports are only used in the getAbsolutePath function, which is only generated for non-Angular Storybook projects. This change prevents unnecessary imports from being added to Angular Storybook configurations.
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 42214de
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Dec 9, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The fileURLToPath and dirname imports are only used in the getAbsolutePath function, which is only generated for non-Angular Storybook projects.
Expected Behavior
This change prevents unnecessary imports from being added to Angular Storybook configurations.