fix(core): prevent Nx Console prompt from blocking non-interactive commands#33646
Merged
FrozenPandaz merged 4 commits intomasterfrom Nov 28, 2025
Merged
fix(core): prevent Nx Console prompt from blocking non-interactive commands#33646FrozenPandaz merged 4 commits intomasterfrom
FrozenPandaz merged 4 commits intomasterfrom
Conversation
…mmands The Nx Console installation prompt was blocking commands when run in non-interactive contexts (CI, AI agents, piped commands). The prompt only checked `process.stdout.isTTY` but not `process.stdin.isTTY`, causing it to wait for input that would never arrive. Now checks: - Both stdin and stdout are TTY (truly interactive) - Not running in a CI environment Fixes #33552
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 1bcf745
☁️ Nx Cloud last updated this comment at |
AgentEnder
approved these changes
Nov 27, 2025
…mmands The Nx Console installation prompt was blocking commands when run in non-interactive contexts (CI, AI agents, piped commands). The prompt only checked `process.stdout.isTTY` but not `process.stdin.isTTY`, causing it to wait for input that would never arrive. Now checks: - Both stdin and stdout are TTY (truly interactive) - Not running in a CI environment Fixes #33552 [Self-Healing CI Rerun]
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…mmands The Nx Console installation prompt was blocking commands when run in non-interactive contexts (CI, AI agents, piped commands). The prompt only checked `process.stdout.isTTY` but not `process.stdin.isTTY`, causing it to wait for input that would never arrive. Now checks: - Both stdin and stdout are TTY (truly interactive) - Not running in a CI environment Fixes #33552 [Self-Healing CI Rerun]
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we reran your CI automatically.
🎓 Learn more about Self-Healing CI on nx.dev
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The Nx Console installation prompt blocks commands when run in non-interactive contexts such as:
The prompt only checked
process.stdout.isTTYbut notprocess.stdin.isTTY, causing it to wait indefinitely for input that would never arrive.Expected Behavior
Commands should complete without prompting when run in non-interactive environments.
Related Issue(s)
Fixes #33552
Solution
Updated the check to verify:
stdinandstdoutare TTY (truly interactive terminal)isCI()utility)This ensures the prompt only appears when the user can actually provide input.