fix(linter): base eslint config should ignore out-tsc directories#33639
Merged
fix(linter): base eslint config should ignore out-tsc directories#33639
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 02a518b
☁️ Nx Cloud last updated this comment at |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we reran your CI automatically.
🎓 Learn more about Self-Healing CI on nx.dev
Co-authored-by: Coly010 <Coly010@users.noreply.github.com>
Co-authored-by: Coly010 <Coly010@users.noreply.github.com> [Self-Healing CI Rerun]
Co-authored-by: Coly010 <Coly010@users.noreply.github.com> [Self-Healing CI Rerun]
c9c6274 to
02a518b
Compare
leosvelperez
approved these changes
Nov 27, 2025
jaysoo
approved these changes
Nov 27, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 27, 2025
…3639) ## Current Behavior The base `eslint` config will ignore `**/dist` but not `**/out-tsc`. This can cause issues if lint is run after a `typecheck` which has placed `.d.ts` files into an `out-tsc` directory. ## Expected Behavior Base eslint config should ignore `**/out-tsc` --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> Co-authored-by: Coly010 <Coly010@users.noreply.github.com> (cherry picked from commit f87e20f)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The base
eslintconfig will ignore**/distbut not**/out-tsc.This can cause issues if lint is run after a
typecheckwhich has placed.d.tsfiles into anout-tscdirectory.Expected Behavior
Base eslint config should ignore
**/out-tsc