fix(storybook): remove STORYBOOK_PROJECT_ROOT when running automigrate to prevent hanging#33567
Conversation
…e to prevent hanging
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 651f988
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Nov 21, 2025
jaysoo
added a commit
that referenced
this pull request
Nov 21, 2025
…e to prevent hanging (#33567) This PR fixes an issue where migrations can hang due to out invocation of `storybook automigrate`. We are passing both `--config-dir` and `STORYBOOK_PROJECT_ROOT`, the latter causes hanging with Storybook v9. https://www.loom.com/share/39bbb350595c4a13aef86ec29f4b748f ## Current Behavior Hangs ## Expected Behavior Does not hang ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #32492
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where migrations can hang due to out invocation of
storybook automigrate. We are passing both--config-dirandSTORYBOOK_PROJECT_ROOT, the latter causes hanging with Storybook v9.https://www.loom.com/share/39bbb350595c4a13aef86ec29f4b748f
Current Behavior
Hangs
Expected Behavior
Does not hang
Related Issue(s)
Fixes #32492