Skip to content

feat(linter): add peerDepsVersionStrategy option to dependency-checks#33417

Merged
jaysoo merged 5 commits intonrwl:masterfrom
hosembafer:feature/peer-deps-version-strategy
Dec 29, 2025
Merged

feat(linter): add peerDepsVersionStrategy option to dependency-checks#33417
jaysoo merged 5 commits intonrwl:masterfrom
hosembafer:feature/peer-deps-version-strategy

Conversation

@hosembafer
Copy link
Copy Markdown
Contributor

@hosembafer hosembafer commented Nov 8, 2025

Adds a new peerDepsVersionStrategy option that allows configuring how peer dependencies versions are set when auto-fixing. When set to 'workspace', peer dependencies will use 'workspace:*' instead of the installed or root package version. Defaults to 'installed' to maintain backward compatibility.

Current Behavior

A concrete peer dependency version is being fixed.

Expected Behavior

User can choose between installed and workspace version strategies.

@hosembafer hosembafer requested review from a team as code owners November 8, 2025 18:04
@hosembafer hosembafer requested a review from meeroslav November 8, 2025 18:04
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 8, 2025 •
edited
Loading

✅ Deploy Preview for nx-docs canceled.

Name Link
🔨 Latest commit 33c3174
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/690f861915acd100080277cc

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nx-dev Ready Ready Preview Dec 29, 2025 7:59pm

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Nov 8, 2025
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/eslint-plugin/src/rules/dependency-checks.ts
@hosembafer hosembafer force-pushed the feature/peer-deps-version-strategy branch from 63a038c to 281e5f7 Compare November 11, 2025 21:10
@hosembafer hosembafer force-pushed the feature/peer-deps-version-strategy branch from 281e5f7 to a0d061e Compare November 12, 2025 17:33
graphite-app[bot]
graphite-app Bot reviewed Nov 12, 2025
View reviewed changes
Comment thread packages/eslint-plugin/src/rules/dependency-checks.spec.ts
@hosembafer
Copy link
Copy Markdown
Contributor Author

hosembafer commented Nov 15, 2025

Hi @meeroslav , could you please let me know when you might be able to take a look at this change?

@ashotkosakyan
Copy link
Copy Markdown

ashotkosakyan commented Nov 21, 2025

Any update on this?

@jaysoo
Copy link
Copy Markdown
Member

jaysoo commented Dec 29, 2025

Hey @hosembafer, thanks for the PR. It makes sense to write workspace:* if something is missing, but for checking we should also make sure workspace:~ and workspace:^ are supported. We should also clarify that this is only for PNPM.

hosembafer and others added 4 commits December 29, 2025 14:23
@hosembafer @jaysoo
feat(linter): add peerDepsVersionStrategy option to dependency-checks…
0b62e3f 
… rule

Adds a new peerDepsVersionStrategy option that allows configuring how peer dependencies versions are set when auto-fixing.
When set to 'workspace', peer dependencies will use 'workspace:*' instead of the installed or root package version.
Defaults to 'installed' to maintain backward compatibility.
@hosembafer @jaysoo
fix(linter): only apply workspace:* to workspace packages in peerDeps…
51e9370 
…VersionStrategy
@hosembafer @jaysoo
fix(linter): use workspace:* for all peer deps when peerDepsVersionSt…
113091d 
…rategy is workspace
@jaysoo
chore(misc): support multiple workspace specifiers
c8b8eb8
@jaysoo jaysoo force-pushed the feature/peer-deps-version-strategy branch from 2d78843 to c8b8eb8 Compare December 29, 2025 19:29
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Dec 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e7a0450

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 22m 27s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 40s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 11s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-29 20:21:42 UTC

@jaysoo jaysoo merged commit 97fde57 into nrwl:master Dec 29, 2025
20 checks passed
@hosembafer
Copy link
Copy Markdown
Contributor Author

hosembafer commented Dec 30, 2025

Hey @hosembafer, thanks for the PR. It makes sense to write workspace:* if something is missing, but for checking we should also make sure workspace:~ and workspace:^ are supported. We should also clarify that this is only for PNPM.

Hi @jaysoo , I see you pushed missing parts! Thank you!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 5, 2026

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@jaysoo jaysoo jaysoo approved these changes

@meeroslav meeroslav Awaiting requested review from meeroslav meeroslav was automatically assigned from nrwl/nx-linter-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hosembafer @ashotkosakyan @jaysoo