fix(docker): handle undefined options when creating graph#33235
Merged
fix(docker): handle undefined options when creating graph#33235
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit a44c454
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jaysoo
approved these changes
Oct 24, 2025
Contributor
|
@Coly010 it would be really nice to have this released under a beta tag so that I can unblock myself. Thanks! |
FrozenPandaz
pushed a commit
that referenced
this pull request
Oct 27, 2025
## Current Behavior When `@nx/docker` is registered via string only (`nxJson.plugins: ["@nx/docker"]`, project graph creation fails because we try to access `options.buildTarget`. ## Expected Behavior Handle undefined `options` gracefully, and still create the default target. ## Related Issue(s) Fixes NXC-3320 (cherry picked from commit 54bd3c4)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When
@nx/dockeris registered via string only (nxJson.plugins: ["@nx/docker"], project graph creation fails because we try to accessoptions.buildTarget.Expected Behavior
Handle undefined
optionsgracefully, and still create the default target.Related Issue(s)
Fixes NXC-3320