fix(maven): use File.isAbsolute for cross-platform path detection#33195
Merged
FrozenPandaz merged 1 commit intomasterfrom Oct 23, 2025
Merged
fix(maven): use File.isAbsolute for cross-platform path detection#33195FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 6de1018
☁️ Nx Cloud last updated this comment at |
9443330 to
9c97e5c
Compare
9c97e5c to
6de1018
Compare
MaxKless
approved these changes
Oct 23, 2025
Replaced string-based path checking (startsWith("/")) with File.isAbsolute()
for more robust cross-platform absolute path detection in the Maven plugin.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
FrozenPandaz
added a commit
that referenced
this pull request
Oct 27, 2025
…3195) ## Current Behavior The Maven plugin currently checks if a path is absolute by using `outputFile.startsWith("/")`. This only works on Unix-like systems and fails on Windows where absolute paths start with a drive letter (e.g., `C:\`). ## Expected Behavior The Maven plugin should correctly identify absolute paths on all platforms (Windows, macOS, Linux) using the platform-agnostic `File.isAbsolute()` method. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> N/A - This is a proactive bug fix for cross-platform compatibility. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 500a4c9)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The Maven plugin currently checks if a path is absolute by using
outputFile.startsWith("/"). This only works on Unix-like systems and fails on Windows where absolute paths start with a drive letter (e.g.,C:\).Expected Behavior
The Maven plugin should correctly identify absolute paths on all platforms (Windows, macOS, Linux) using the platform-agnostic
File.isAbsolute()method.Related Issue(s)
N/A - This is a proactive bug fix for cross-platform compatibility.
🤖 Generated with Claude Code