fix(core): stream without prefixes showing tui#33194
Merged
FrozenPandaz merged 1 commit intonrwl:masterfrom Oct 24, 2025
Merged
fix(core): stream without prefixes showing tui#33194FrozenPandaz merged 1 commit intonrwl:masterfrom
FrozenPandaz merged 1 commit intonrwl:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
AgentEnder
approved these changes
Oct 23, 2025
Contributor
|
View your CI Pipeline Execution ↗ for commit 89303fe
☁️ Nx Cloud last updated this comment at |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
hugs7
commented
Oct 23, 2025
Contributor
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
These changes fix formatting inconsistencies by removing trailing commas from function parameters and array elements in the shouldUseTui function. We aligned the code with the project's Prettier configuration to ensure consistent code style across the codebase.
Suggested Fix changes
diff --git a/packages/nx/src/tasks-runner/is-tui-enabled.ts b/packages/nx/src/tasks-runner/is-tui-enabled.ts
index 9447dd4f27..293bed4906 100644
--- a/packages/nx/src/tasks-runner/is-tui-enabled.ts
+++ b/packages/nx/src/tasks-runner/is-tui-enabled.ts
@@ -24,7 +24,7 @@ export function isTuiEnabled() {
export function shouldUseTui(
nxJson: NxJsonConfiguration,
nxArgs: NxArgs,
- skipCapabilityCheck = process.env.NX_TUI_SKIP_CAPABILITY_CHECK === 'true',
+ skipCapabilityCheck = process.env.NX_TUI_SKIP_CAPABILITY_CHECK === 'true'
) {
// If the current terminal/environment is not capable of displaying the TUI, we don't run it
const isWindows = process.platform === 'win32';
@@ -34,7 +34,7 @@ export function shouldUseTui(
if (typeof nxArgs.tui === 'boolean') {
if (nxArgs.tui && !isCapable) {
logger.warn(
- 'Nx Terminal UI was not enabled as it is not supported in this environment.',
+ 'Nx Terminal UI was not enabled as it is not supported in this environment.'
);
return false;
}
@@ -47,7 +47,7 @@ export function shouldUseTui(
if (
['static', 'stream', 'stream-without-prefixes', 'dynamic-legacy'].includes(
- nxArgs.outputStyle,
+ nxArgs.outputStyle
)
) {
// If the user has specified a non-TUI output style, we disable the TUI
Or Apply changes locally with:
npx nx-cloud apply-locally kUsG-GCYD
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 To learn more about Self Healing CI, please visit nx.dev
test(nx): add stream without prefix case fix(nx): stream check fix(nx): set prefix explicit false style(nx): formatting
3a47a26 to
89303fe
Compare
Contributor
|
Thank you for your contribution! 🎉 LGTM |
Contributor
Author
|
No worries. Thanks for quick review @AgentEnder @FrozenPandaz |
FrozenPandaz
pushed a commit
that referenced
this pull request
Oct 27, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior When using `--output-style=stream-without-prefixes` nx incorrectly shows the TUI instead of streaming ## Expected Behavior When using `--output-style=stream-without-prefixes`, nx should stream with no prefixes just like it does with `--output-style=stream` ## Related Issue(s) Fixes #32535 Co-authored-by: Hugo Burton <hugo.burton@westpac.com.au> (cherry picked from commit 4a4b780)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using
--output-style=stream-without-prefixesnx incorrectly shows the TUI instead of streamingExpected Behavior
When using
--output-style=stream-without-prefixes, nx should stream with no prefixes just like it does with--output-style=streamRelated Issue(s)
Fixes #32535