fix(nx-dev): handle null github data#33061
Merged
barbados-clemens merged 2 commits intomasterfrom Oct 14, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit e46c6d7
☁️ Nx Cloud last updated this comment at |
1ed285b to
cb69d27
Compare
jaysoo
approved these changes
Oct 14, 2025
cb69d27 to
e46c6d7
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Oct 15, 2025
technically the fix to plugin stats now showing up was expired GH token. But refactored the plugin stats fetching to skip locally unless NX_DOCS_PLUGIN_STATS env var is set to help speed up local serves/builds since 99% of the time we're not concerned with the plugin-registry page. along with trying to centralized the logic between 1st/3rd party plugins since it was a little confusing from my initial impl. (cherry picked from commit 61b2796)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
technically the fix to plugin stats now showing up was expired GH token.
But refactored the plugin stats fetching to skip locally unless NX_DOCS_PLUGIN_STATS env var is set to help speed up local serves/builds since 99% of the time we're not concerned with the plugin-registry page.
along with trying to centralized the logic between 1st/3rd party plugins since it was a little confusing from my initial impl.