fix(nx-dev): respect NX_DEV_URL in sitemap checker#33058
Merged
barbados-clemens merged 1 commit intomasterfrom Oct 13, 2025
Merged
fix(nx-dev): respect NX_DEV_URL in sitemap checker#33058barbados-clemens merged 1 commit intomasterfrom
barbados-clemens merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| join(directoryPath, internalSitemap.loc.replace('https://nx.dev', '')), | ||
| join( | ||
| directoryPath, | ||
| internalSitemap.loc.replace(siteUrl, '').replace('https://nx.dev', '') |
Contributor
Author
There was a problem hiding this comment.
have to always check for nx.dev bc hardcoded in some places?
Contributor
|
View your CI Pipeline Execution ↗ for commit ed1be8f
☁️ Nx Cloud last updated this comment at |
juristr
approved these changes
Oct 13, 2025
philipjfulcher
pushed a commit
that referenced
this pull request
Oct 13, 2025
Sitemap in CI can have different `NX_DEV_URL` values which can make the link checker work locally but not in CI
philipjfulcher
added a commit
that referenced
this pull request
Oct 13, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Oct 15, 2025
Sitemap in CI can have different `NX_DEV_URL` values which can make the link checker work locally but not in CI (cherry picked from commit f425526)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sitemap in CI can have different
NX_DEV_URLvalues which can make the link checker work locally but not in CI