fix(nx-dev): update nextjs internal-link-checker to include astro urls#33045
Merged
fix(nx-dev): update nextjs internal-link-checker to include astro urls#33045
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 05064a0
☁️ Nx Cloud last updated this comment at |
blog and marketing pages will still link to astro docs, so depend on the astro sitemap to check all links available to be used. NOTE: the specific header links (url fragments) are skipped for pages that come from astro docs (prefixed with /docs) due to not having a simple way to create these lists without parsing all the build html files out and that's not the part we really care about
778e9ba to
05064a0
Compare
bcabanes
approved these changes
Oct 10, 2025
bcabanes
reviewed
Oct 10, 2025
jaysoo
approved these changes
Oct 10, 2025
philipjfulcher
pushed a commit
that referenced
this pull request
Oct 13, 2025
#33045) blog and marketing pages will still link to astro docs, so depend on the astro sitemap to check all links available to be used. NOTE: the specific header links (url fragments) are skipped for pages that come from astro docs (prefixed with /docs) due to not having a simple way to create these lists without parsing all the build html files out and that's not the part we really care about confirmed working #33042 and #33036 which are blocked until this change merges Fixes DOC-264
philipjfulcher
added a commit
that referenced
this pull request
Oct 13, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Oct 15, 2025
#33045) blog and marketing pages will still link to astro docs, so depend on the astro sitemap to check all links available to be used. NOTE: the specific header links (url fragments) are skipped for pages that come from astro docs (prefixed with /docs) due to not having a simple way to create these lists without parsing all the build html files out and that's not the part we really care about confirmed working #33042 and #33036 which are blocked until this change merges Fixes DOC-264 (cherry picked from commit bfaa91b)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blog and marketing pages will still link to astro docs, so depend on the
astro sitemap to check all links available to be used.
NOTE: the specific header links (url fragments) are skipped for pages
that come from astro docs (prefixed with /docs) due to not having a
simple way to create these lists without parsing all the build html
files out and that's not the part we really care about
confirmed working #33042 and #33036 which are blocked until this change merges
Fixes DOC-264