feat(nest): ensure dependencies are added to project's package.json #32548#32986
feat(nest): ensure dependencies are added to project's package.json #32548#32986
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit c099d4c
☁️ Nx Cloud last updated this comment at |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
9230383 to
6598d43
Compare
There was a problem hiding this comment.
Nx Cloud has identified a possible root cause for your failed CI:
The failure is classified as 'environment_state' rather than 'code_change' for the following reasons:
-
No Direct Correlation with PR Changes: The PR's intent is to "ensure NestJS dependencies are added to project's package.json" (issue #32548). However, the failing test is for Angular Module Federation with federated libraries, which has no logical connection to NestJS dependency management.
-
Unrelated Test Domain: The test failure occurs in
module-federation-lib.test.tstesting Angular Module Federation functionality, while the PR changes specifically target NestJS project generation to ensure dependencies are properly added to package.json files for Docker lockfile pruning scenarios. -
Environmental Indicators Present: The error includes multiple instances of Corepack warnings about missing 'packageManager' fields being auto-added:
- "The local project doesn't define a 'packageManager' field. Corepack will now add one referencing pnpm@9.15.9..."
- This suggests the test environment has Corepack behavior that is interfering with test execution
-
Test Infrastructure Issue: The failure is in test setup/execution (
runCLIincommand-utils.ts:399:26) rather than in actual application code, suggesting an environmental or test infrastructure problem. -
No Code Changes in Failing Test Area: The PR diff would show changes to NestJS generators, not Angular Module Federation test code. The failure point is unrelated to any code that would be modified by ensuring NestJS dependencies are in package.json.
-
Timing Inconsistency: One test in the suite passed (taking 207 seconds) while another failed (taking 11 seconds), which suggests environmental instability rather than a systematic code issue introduced by the changes.
The failure appears to be caused by environmental state issues related to package manager detection and Corepack configuration in the test environment, not by the PR's changes to NestJS dependency management.
A code change would likely not resolve this issue, so no action was taken.
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
6598d43 to
c099d4c
Compare
…32548 (#32986) ## Current Behavior NestJS dependencies are not added to the project's package.json leading to issues when pruning lockfile for dockerfiles. ## Expected Behavior Ensure NestJS dependencies are added to the project's package.json. ## Related Issue(s) Fixes #32548 (cherry picked from commit 90f9085)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
NestJS dependencies are not added to the project's package.json leading to issues when pruning lockfile for dockerfiles.
Expected Behavior
Ensure NestJS dependencies are added to the project's package.json.
Related Issue(s)
Fixes #32548