feat(js)!: remove the experimental and deprecated inlining feature from the tsc and swc executors#32783
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit c5a1e0f
☁️ Nx Cloud last updated this comment at |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
2974d26 to
c916646
Compare
There was a problem hiding this comment.
Nx Cloud has identified a possible root cause for your failed CI:
The pull request removes the experimental inlining feature from the @nx/js:tsc and @nx/js:swc executors, including the removal of the external and externalBuildTargets options. The changes include:
- Removal of deprecated options from schema files
- Deletion of inlining-related utility functions and test files
- Updates to documentation examples
- Addition of a migration to clean up existing configurations
The failing test is e2e-release:e2e-ci--src/release-publishable-libraries-ts-solution.test.ts, which tests release functionality for publishable libraries in TypeScript solution setups. The test failures are snapshot mismatches in the expected tarball contents - specifically missing .d.ts.map files for React and React Native library tests.
However, these test failures are unrelated to the pull request changes because:
- The failing tests are for release/publishing functionality, not for the build executors that were modified
- The PR changes focus on removing inlining features from
@nx/js:tscand@nx/js:swcexecutors - The snapshot differences show missing TypeScript declaration map files (
.d.ts.map), which would be generated during TypeScript compilation, not related to the inlining feature removal - The PR does not modify any TypeScript compilation settings that would affect declaration map generation
- No similar task failures are present in the
<similar_task_failures>section, indicating this might be an environmental issue
The test failures appear to be related to TypeScript declaration map generation during the release process, which is completely separate from the inlining feature removal that this PR implements. This suggests the failures are due to environmental factors or unrelated changes in the codebase, not the specific changes made in this pull request.
A code change would likely not resolve this issue, so no action was taken.
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
2a50463 to
c0971f1
Compare
…m js and swc executors
c916646 to
c5a1e0f
Compare
…om the `tsc` and `swc` executors (#32783) ## Current Behavior The experimental inlining feature in the `@nx/js:tsc` and `@nx/js:swc` executors is deprecated. ## Expected Behavior The experimental inlining feature in the `@nx/js:tsc` and `@nx/js:swc` executors should be removed. BREAKING CHANGE: The experimental inlining feature in the `@nx/js:tsc` and `@nx/js:swc` executors was removed. A migration will remove the related options (`external` and `externalBuildTargets`). Still, if you use or rely on the feature, you need to make your dependencies buildable or use a different build tool with bundling capabilities.
…om the `tsc` and `swc` executors (#32783) ## Current Behavior The experimental inlining feature in the `@nx/js:tsc` and `@nx/js:swc` executors is deprecated. ## Expected Behavior The experimental inlining feature in the `@nx/js:tsc` and `@nx/js:swc` executors should be removed. BREAKING CHANGE: The experimental inlining feature in the `@nx/js:tsc` and `@nx/js:swc` executors was removed. A migration will remove the related options (`external` and `externalBuildTargets`). Still, if you use or rely on the feature, you need to make your dependencies buildable or use a different build tool with bundling capabilities.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The experimental inlining feature in the
@nx/js:tscand@nx/js:swcexecutors is deprecated.Expected Behavior
The experimental inlining feature in the
@nx/js:tscand@nx/js:swcexecutors should be removed.BREAKING CHANGE: The experimental inlining feature in the
@nx/js:tscand@nx/js:swcexecutors was removed. A migration will remove the related options (externalandexternalBuildTargets). Still, if you use or rely on the feature, you need to make your dependencies buildable or use a different build tool with bundling capabilities.