fix(angular): install a compatible version of jest for angular#32744
fix(angular): install a compatible version of jest for angular#32744leosvelperez merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit 870a819
☁️ Nx Cloud last updated this comment at |
06d4d9e to
870a819
Compare
| } | ||
| } | ||
| }, | ||
| "21.3.5-jest": { |
There was a problem hiding this comment.
We cannot change published versions, but with this change, if users migrate to the latest from a version lower than Nx v21.3.5, it will not bump the jest-preset-angular package.
I considered adding a migration to lower the version of jest-preset-angular (and Jest), but users in this situation are already handling it somehow, and it can get complex to revert some migration changes done for Jest v30.
| }, | ||
| "rename-test-path-pattern": { | ||
| "version": "21.3.0-beta.3", | ||
| "requires": { |
There was a problem hiding this comment.
This was incorrectly requiring Jest v30. Regardless of the Jest version, we renamed the executor option from that version of Nx onwards, so we need the migration to run.
## Current Behavior Generating Angular projects with Jest results in Jest v30 being used, which is not supported by Angular and causes peer dependency errors. ## Expected Behavior Generating Angular projects with Jest should install a compatible version of Jest (Angular currently supports `^29.5.0`). (cherry picked from commit 040d7d7)
## Current Behavior Generating Angular projects with Jest results in Jest v30 being used, which is not supported by Angular and causes peer dependency errors. ## Expected Behavior Generating Angular projects with Jest should install a compatible version of Jest (Angular currently supports `^29.5.0`).
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Generating Angular projects with Jest results in Jest v30 being used, which is not supported by Angular and causes peer dependency errors.
Expected Behavior
Generating Angular projects with Jest should install a compatible version of Jest (Angular currently supports
^29.5.0).