Skip to content

fix(core): exit fork process and children when ipc connection closes#32681

Merged
FrozenPandaz merged 1 commit intomasterfrom
core/fork-ipc-exit-listeners
Sep 11, 2025
Merged

fix(core): exit fork process and children when ipc connection closes#32681
FrozenPandaz merged 1 commit intomasterfrom
core/fork-ipc-exit-listeners

Conversation

@leosvelperez
Copy link
Copy Markdown
Member

Fixes orphaned fork.js processes that occur when the parent Rust PseudoTerminal process terminates faster than the fork process can complete its cleanup, causing the fork to hang during Node.js socket cleanup.

@leosvelperez leosvelperez self-assigned this Sep 10, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner September 10, 2025 15:22
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Sep 11, 2025 7:42am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Sep 10, 2025

View your CI Pipeline Execution ↗ for commit 0082abf

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 48m 31s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded 1m 7s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-11 08:24:50 UTC

Comment thread packages/nx/src/tasks-runner/fork.ts
@FrozenPandaz FrozenPandaz merged commit 555c69c into master Sep 11, 2025
15 checks passed
@FrozenPandaz FrozenPandaz deleted the core/fork-ipc-exit-listeners branch September 11, 2025 14:00
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants