fix(bundling): postcss-cli-resources should handle relative urls #32582#32658
fix(bundling): postcss-cli-resources should handle relative urls #32582#32658FrozenPandaz merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit f4e8a4b
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
We have identified and fixed the corrupted Gradle wrapper scripts that had invalid CLASSPATH configurations and incorrect command execution parameters. These changes will restore proper Gradle functionality by setting the correct classpath and using the appropriate wrapper main class.
We verified this fix by re-running e2e-react:e2e-ci--src/module-federation/core.webpack.test.ts.
diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar
index 9bbc975..1b33c55 100644
Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
|
Thank you! ❤️ |
… (#32658) ## Current Behavior Relative urls are not being handled correctly in the `postcss-cli-resources` Plugins for Webpack and Rspack after switching to use WHATWG URL in favour of the deprecated `url.parse()` method. ## Expected Behavior Ensure relatives are handled appropriately by resolving them based on the context of the current resource being loaded. ## Related Issue(s) Fixes #32582 (cherry picked from commit 95e7b49)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Relative urls are not being handled correctly in the
postcss-cli-resourcesPlugins for Webpack and Rspack after switching to use WHATWG URL in favour of the deprecatedurl.parse()method.Expected Behavior
Ensure relatives are handled appropriately by resolving them based on the context of the current resource being loaded.
Related Issue(s)
Fixes #32582