Skip to content

fix(core): ensure only supported bundlers are used for angular fallback to default#32655

Merged
Coly010 merged 1 commit intomasterfrom
cnw-angular-esbuild-default
Sep 8, 2025
Merged

fix(core): ensure only supported bundlers are used for angular fallback to default#32655
Coly010 merged 1 commit intomasterfrom
cnw-angular-esbuild-default

Conversation

@Coly010
Copy link
Copy Markdown
Contributor

@Coly010 Coly010 commented Sep 8, 2025

Current Behavior

If an invalid bundler is provided to create-nx-workspace for the angular-monorepo preset, it defaults to webpack.

Expected Behavior

Invalid bundler option should default to the default provided within in the angular app generator

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Sep 8, 2025 2:35pm

@Coly010 Coly010 requested a review from a team as a code owner September 8, 2025 08:41
@Coly010 Coly010 self-assigned this Sep 8, 2025
@Coly010 Coly010 requested a review from FrozenPandaz September 8, 2025 08:41
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Sep 8, 2025

View your CI Pipeline Execution ↗ for commit d08f92d

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 43m 43s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 47s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 3s View ↗
nx documentation ✅ Succeeded 25s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-08 15:12:55 UTC

Comment thread packages/workspace/src/generators/preset/preset.ts Outdated
@Coly010 Coly010 merged commit ceaa58e into master Sep 8, 2025
16 checks passed
@Coly010 Coly010 deleted the cnw-angular-esbuild-default branch September 8, 2025 15:39
FrozenPandaz pushed a commit that referenced this pull request Sep 10, 2025
…ck to default (#32655)

## Current Behavior
If an invalid bundler is provided to `create-nx-workspace` for the
`angular-monorepo` preset, it defaults to `webpack`.

## Expected Behavior
Invalid bundler option should default to the default provided within in
the angular app generator

(cherry picked from commit ceaa58e)
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants