fix(core): invalidate project graph when external nodes change#32626
Merged
FrozenPandaz merged 3 commits intomasterfrom Sep 8, 2025
Merged
fix(core): invalidate project graph when external nodes change#32626FrozenPandaz merged 3 commits intomasterfrom
FrozenPandaz merged 3 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 7a21f09
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
requested changes
Sep 5, 2025
FrozenPandaz
requested changes
Sep 5, 2025
FrozenPandaz
requested changes
Sep 5, 2025
| }); | ||
| } | ||
|
|
||
| function getExternalNodesData( |
Contributor
There was a problem hiding this comment.
Do we have to reduce this or can we hash the whole thing?
Member
Author
There was a problem hiding this comment.
I think we should. Benchmarking both approaches in this repo:
Hash full external nodes: 27.798042000000002ms
Reduce and hash external nodes: 4.348999999999997msThat's a ~6x time reduction, which is significant.
0cabd9a to
7a21f09
Compare
FrozenPandaz
approved these changes
Sep 8, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 10, 2025
## Current Behavior When external nodes change, the project graph cache is not invalidated. This can sometimes lead to missing dependencies due to reusing cached dependencies for nodes that no longer exist. ## Expected Behavior When external nodes change, the project graph cache should be invalidated. (cherry picked from commit 5011ecd)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When external nodes change, the project graph cache is not invalidated. This can sometimes lead to missing dependencies due to reusing cached dependencies for nodes that no longer exist.
Expected Behavior
When external nodes change, the project graph cache should be invalidated.