feat(core): add bold styling to terminal pane title when focused#32462
Merged
FrozenPandaz merged 1 commit intomasterfrom Sep 9, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit f691453
☁️ Nx Cloud last updated this comment at |
Copilot
AI
changed the title
[WIP] In the rust terminal pane, lets bold the title when its focused in addition to the color swap
feat(tui): add bold styling to terminal pane title when focused
Aug 21, 2025
Member
|
@copilot combine the to ternaries, should be able to do something like |
Contributor
Author
9213a94 to
671b9a1
Compare
fix(core): add bold stylng to terminal pane title when focused to emphasize it Co-authored-by: AgentEnder <6933928+AgentEnder@users.noreply.github.com> refactor(tui): combine ternary expressions into match statement for terminal pane styling Co-authored-by: AgentEnder <6933928+AgentEnder@users.noreply.github.com>
671b9a1 to
f691453
Compare
FrozenPandaz
approved these changes
Sep 9, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 10, 2025
## Current Behavior Terminal panes in the TUI show focus state through color changes only - focused panes display the task name in primary foreground color while unfocused panes use secondary foreground color. ## Expected Behavior Terminal panes should provide stronger visual feedback when focused by making the title bold in addition to the existing color change, consistent with other TUI components like the dependency view. ## Related Issue(s) This enhancement improves the visual hierarchy and makes it easier for users to identify which terminal pane currently has focus, especially in multi-pane layouts. ## Changes Made - Modified the title styling logic in `TerminalPane::render()` to conditionally apply `Modifier::BOLD` when the pane is focused - Added a test to verify the focus state behavior is correctly implemented - The change follows the existing pattern used in other components and maintains backward compatibility The implementation uses a conditional modifier that applies bold styling only when `state.is_focused` is true, leaving unfocused panes unchanged. This provides consistent visual feedback across the TUI while preserving existing functionality. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AgentEnder <6933928+AgentEnder@users.noreply.github.com> (cherry picked from commit c586749)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Terminal panes in the TUI show focus state through color changes only - focused panes display the task name in primary foreground color while unfocused panes use secondary foreground color.
Expected Behavior
Terminal panes should provide stronger visual feedback when focused by making the title bold in addition to the existing color change, consistent with other TUI components like the dependency view.
Related Issue(s)
This enhancement improves the visual hierarchy and makes it easier for users to identify which terminal pane currently has focus, especially in multi-pane layouts.
Changes Made
TerminalPane::render()to conditionally applyModifier::BOLDwhen the pane is focusedThe implementation uses a conditional modifier that applies bold styling only when
state.is_focusedis true, leaving unfocused panes unchanged. This provides consistent visual feedback across the TUI while preserving existing functionality.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.