Skip to content

fix(angular): do not update project configuration when not changes were made in migration#32448

Merged
FrozenPandaz merged 1 commit intomasterfrom
angular/fix-tsconfig-option-migration
Aug 21, 2025
Merged

fix(angular): do not update project configuration when not changes were made in migration#32448
FrozenPandaz merged 1 commit intomasterfrom
angular/fix-tsconfig-option-migration

Conversation

@leosvelperez
Copy link
Copy Markdown
Member

Avoid writing back the project configuration when the migration made no changes to it.

@leosvelperez leosvelperez self-assigned this Aug 21, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner August 21, 2025 13:33
@leosvelperez leosvelperez requested a review from Coly010 August 21, 2025 13:33
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Aug 21, 2025 2:10pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Aug 21, 2025

🤖 Nx Cloud AI has a fix for the failures below

fix(e2e): ensure Playwright browsers are installed on CI when missing

🟢 Verified, ready to apply • View Fix ↗


View your CI Pipeline Execution ↗ for commit 6074a38

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ❌ Failed 25m 29s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 7s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-21 16:44:15 UTC

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) August 21, 2025 13:34
@FrozenPandaz FrozenPandaz disabled auto-merge August 21, 2025 16:12
@FrozenPandaz FrozenPandaz merged commit 1fda6fe into master Aug 21, 2025
7 of 10 checks passed
@FrozenPandaz FrozenPandaz deleted the angular/fix-tsconfig-option-migration branch August 21, 2025 16:12
FrozenPandaz pushed a commit that referenced this pull request Aug 22, 2025
…re made in migration (#32448)

Avoid writing back the project configuration when the migration made no
changes to it.

(cherry picked from commit 1fda6fe)
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants