Skip to content

fix(angular-rspack): do not error on server budget violation#32445

Merged
Coly010 merged 3 commits intomasterfrom
angular-rspack-server-budgets
Aug 21, 2025
Merged

fix(angular-rspack): do not error on server budget violation#32445
Coly010 merged 3 commits intomasterfrom
angular-rspack-server-budgets

Conversation

@Coly010
Copy link
Copy Markdown
Contributor

@Coly010 Coly010 commented Aug 21, 2025

Current Behavior

Angular with Esbuild does not error when server bundles violate the budgets.
Currently, Angular Rspack will error when server bundles violate the budgets.

Expected Behavior

Match the behaviour with Angular with Esbuild in Angular Rspack.
Do not error when server bundles violate the budgets.

@Coly010 Coly010 requested a review from a team as a code owner August 21, 2025 13:02
@Coly010 Coly010 requested a review from leosvelperez August 21, 2025 13:02
@Coly010 Coly010 self-assigned this Aug 21, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Canceled Canceled Aug 21, 2025 1:44pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Aug 21, 2025

View your CI Pipeline Execution ↗ for commit 9d5e4c1

Command Status Duration Result
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 47s View ↗
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 1m 14s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 8s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 7s View ↗
nx documentation ✅ Succeeded 29s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-21 13:31:12 UTC

Comment thread packages/angular-rspack/src/lib/plugins/angular-rspack-plugin.ts Outdated
Coly010 and others added 2 commits August 21, 2025 14:15
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
@Coly010 Coly010 merged commit 1ca3cfe into master Aug 21, 2025
6 checks passed
@Coly010 Coly010 deleted the angular-rspack-server-budgets branch August 21, 2025 15:34
FrozenPandaz pushed a commit that referenced this pull request Aug 22, 2025
## Current Behavior
Angular with Esbuild does not error when server bundles violate the
budgets.
Currently, Angular Rspack will error when server bundles violate the
budgets.

## Expected Behavior
Match the behaviour with Angular with Esbuild in Angular Rspack.
Do not error when server bundles violate the budgets.

---------

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
(cherry picked from commit 1ca3cfe)
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants