Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 403b6ab
☁️ Nx Cloud last updated this comment at |
605233c to
29079f0
Compare
29079f0 to
3501983
Compare
MaxKless
reviewed
Aug 22, 2025
3501983 to
253c650
Compare
MaxKless
approved these changes
Aug 22, 2025
253c650 to
0178208
Compare
0178208 to
403b6ab
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 22, 2025
…32416) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> We had hardcoded test target names which meant that users who specify custom test suites would not get their atomized tests correctly picked up. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Allow users to configure the `testTargetName` field in their `nx.json` and correctly identify which tasks to atomize. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 82652db)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
We had hardcoded test target names which meant that users who specify custom test suites would not get their atomized tests correctly picked up.
Expected Behavior
Allow users to configure the
testTargetNamefield in theirnx.jsonand correctly identify which tasks to atomize.Related Issue(s)
Fixes #