fix(core): use black for all fg elements when in light theme#32415
fix(core): use black for all fg elements when in light theme#32415AgentEnder merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit 4247899
☁️ Nx Cloud last updated this comment at |
|
Failed to publish a PR release of this pull request, triggered by @AgentEnder. |
e05ef64 to
1daf78a
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32415-1daf78a my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-32415-1daf78a
To request a new release for this pull request, mention someone from the Nx team or the |
1daf78a to
80f53fc
Compare
80f53fc to
c0dc6fd
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32415-80f53fc my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-32415-80f53fc
To request a new release for this pull request, mention someone from the Nx team or the |
| Self { | ||
| is_dark_mode: true, | ||
| primary_fg: Color::White, | ||
| // Originally we specified primary fg as black |
There was a problem hiding this comment.
The comment just needs to explain that Reset means the configured foreground
c0dc6fd to
4247899
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32415-4247899 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-32415-4247899
To request a new release for this pull request, mention someone from the Nx team or the |
| // reset => default foreground color | ||
| primary_fg: Color::Reset, | ||
| secondary_fg: Color::DarkGray, |
There was a problem hiding this comment.
The PR title indicates "use black for all fg elements when in light theme", but there appears to be an inconsistency in the implementation. While primary_fg has been changed to Color::Reset, secondary_fg remains Color::DarkGray.
To fully address the stated goal of the PR, consider updating secondary_fg to either Color::Black or Color::Reset as well, ensuring all foreground elements in light theme have consistent coloring for better readability.
| // reset => default foreground color | |
| primary_fg: Color::Reset, | |
| secondary_fg: Color::DarkGray, | |
| // reset => default foreground color | |
| primary_fg: Color::Reset, | |
| secondary_fg: Color::Reset, | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
## Current Behavior We use dark gray for a secondary fg color, but when dimmed and in certain terminals its not easy to read for light mode ## Expected Behavior We've struggled with getting this pallet right for a while, while we continue working on it we'll just set it to all black ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 885a3d5)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
We use dark gray for a secondary fg color, but when dimmed and in certain terminals its not easy to read for light mode
Expected Behavior
We've struggled with getting this pallet right for a while, while we continue working on it we'll just set it to all black
Related Issue(s)
Fixes #