feat(core): improve Cursor editor detection and extension installation#32374
Merged
FrozenPandaz merged 2 commits intomasterfrom Aug 19, 2025
Merged
feat(core): improve Cursor editor detection and extension installation#32374FrozenPandaz merged 2 commits intomasterfrom
FrozenPandaz merged 2 commits intomasterfrom
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 2edfcd7
☁️ Nx Cloud last updated this comment at |
Contributor
|
should we disable the cursor installation for linux? Because of the |
5011f47 to
e2dd2bc
Compare
- Add CURSOR_TRACE_ID environment variable detection for Cursor - Simplify get_env_var to be purely map-based for better testability - Add Cursor support to extension installation logic - Add test case for CURSOR_TRACE_ID detection This ensures Nx Console extension can be properly installed in Cursor when the CURSOR_TRACE_ID environment variable is present.
The cursor command on Linux opens the IDE instead of running CLI extension commands, causing installation failures. This change disables extension installation for Cursor on Linux while keeping it enabled for Windows and macOS.
e2dd2bc to
2edfcd7
Compare
MaxKless
approved these changes
Aug 19, 2025
FrozenPandaz
added a commit
that referenced
this pull request
Aug 22, 2025
…#32374) ## Summary - Add CURSOR_TRACE_ID environment variable detection for Cursor - Simplify get_env_var to be purely map-based for better testability - Add Cursor support to extension installation logic - Add test case for CURSOR_TRACE_ID detection ## Test plan - [x] All existing tests pass - [x] New test case for CURSOR_TRACE_ID detection passes - [x] Rust code compiles and passes clippy checks - [x] Prepush validation passes This ensures Nx Console extension can be properly installed in Cursor when the CURSOR_TRACE_ID environment variable is present, providing better support for Cursor users. Fixes #[ISSUE_NUMBER] (cherry picked from commit d22677f)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
This ensures Nx Console extension can be properly installed in Cursor when the CURSOR_TRACE_ID environment variable is present, providing better support for Cursor users.
Fixes #[ISSUE_NUMBER]