Skip to content

feat(bundling)!: remove stylus support#32035

Merged
jaysoo merged 2 commits intomasterfrom
fix/remove-stylus-support
Jul 23, 2025
Merged

feat(bundling)!: remove stylus support#32035
jaysoo merged 2 commits intomasterfrom
fix/remove-stylus-support

Conversation

@ndcunningham
Copy link
Copy Markdown
Contributor

@ndcunningham ndcunningham commented Jul 23, 2025

BREAKING CHANGE: Stylus (.styl) files are no longer supported.

Stylus has been deprecated and was slated to be removed in Nx 20.
Now we are removing it.

  • Remove stylus and stylus-loader dependencies
  • Remove deprecated-stylus-loader file
  • Remove stylus configuration from webpack and rspack plugins
  • Remove 'styl' option from rspack generator schemas and TypeScript definitions
  • Remove .styl/.stylus extensions from executor schema file completion globs

MISC
Even though we removed stylus from our repo as a dependency other projects in the workspace still have stylus as an optional dependency:

  • Vite
  • Astro

So we add a placeholder for it since on npm registry there is a security placeholder.

@ndcunningham ndcunningham self-assigned this Jul 23, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 23, 2025 1:52pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jul 23, 2025

View your CI Pipeline Execution ↗ for commit c7c93c7

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 11m 6s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 10s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-23 14:51:48 UTC

@ndcunningham ndcunningham force-pushed the fix/remove-stylus-support branch from b13410b to 4908eea Compare July 23, 2025 07:09
ndcunningham added a commit that referenced this pull request Jul 23, 2025
)

### Changes

The stylus npm registry has been compromised.
So can resolve `stylus` with `npm:ignore@*` it tells the package manager
to replace the dependency with the ignore package from npm registry.

Until we can merge: #32035
JamesHenry pushed a commit that referenced this pull request Jul 23, 2025
)

The stylus npm registry has been compromised.
So can resolve `stylus` with `npm:ignore@*` it tells the package manager
to replace the dependency with the ignore package from npm registry.

Until we can merge: #32035
ndcunningham and others added 2 commits July 23, 2025 15:35
BREAKING CHANGE: Stylus (.styl) files are no longer supported.
- Remove stylus and stylus-loader dependencies from webpack package
- Delete deprecated-stylus-loader.ts file
- Remove stylus configuration from webpack and rspack plugins
- Remove 'styl' option from rspack generator schemas and TypeScript definitions
- Remove .styl/.stylus extensions from executor schema file completion globs
- Update generated documentation to reflect schema changes

Migrate existing .styl files to .scss and ensure content is valid Sass.
@jaysoo jaysoo merged commit 758e793 into master Jul 23, 2025
7 of 8 checks passed
@jaysoo jaysoo deleted the fix/remove-stylus-support branch July 23, 2025 14:56
jaysoo pushed a commit that referenced this pull request Jul 23, 2025
BREAKING CHANGE: Stylus (.styl) files are no longer supported.

Stylus has been deprecated and was slated to be removed in Nx 20.
Now we are removing it.

- Remove `stylus` and `stylus-loader` dependencies
- Remove `deprecated-stylus-loader` file
- Remove `stylus` configuration from `webpack` and `rspack` plugins
- Remove `'styl'` option from `rspack` generator schemas and TypeScript
definitions
- Remove `.styl`/`.stylus` extensions from executor schema file
completion globs

MISC
Even though we removed stylus from our repo as a dependency other
projects in the workspace still have stylus as an optional dependency:
  - Vite
  - Astro

So we add a placeholder for it since on npm registry there is a
_security_ placeholder.

---------

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
jaysoo pushed a commit that referenced this pull request Jul 23, 2025
BREAKING CHANGE: Stylus (.styl) files are no longer supported.

Stylus has been deprecated and was slated to be removed in Nx 20.
Now we are removing it.

- Remove `stylus` and `stylus-loader` dependencies
- Remove `deprecated-stylus-loader` file
- Remove `stylus` configuration from `webpack` and `rspack` plugins
- Remove `'styl'` option from `rspack` generator schemas and TypeScript
definitions
- Remove `.styl`/`.stylus` extensions from executor schema file
completion globs

MISC
Even though we removed stylus from our repo as a dependency other
projects in the workspace still have stylus as an optional dependency:
  - Vite
  - Astro

So we add a placeholder for it since on npm registry there is a
_security_ placeholder.

---------

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shit, here we go again

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants