feat(nx): use platform certificate trust store#31999
Merged
AgentEnder merged 11 commits intonrwl:masterfrom Aug 20, 2025
wereHamster:use-rustls-platform-verifier
Merged
feat(nx): use platform certificate trust store#31999AgentEnder merged 11 commits intonrwl:masterfrom wereHamster:use-rustls-platform-verifier
AgentEnder merged 11 commits intonrwl:masterfrom
wereHamster:use-rustls-platform-verifier
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 0799282
☁️ Nx Cloud last updated this comment at |
Contributor
Author
|
@FrozenPandaz @vsavkin I don't understand the CI failures, they don't look related to my change. |
AgentEnder
approved these changes
Jul 31, 2025
AgentEnder
approved these changes
Aug 20, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 22, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior Certificates in the local trust store are ignored, because reqwest (rustls) is using webpki-roots. ## Expected Behavior Certificates from the local trust store are trusted. This PR solves this the same way as turborepo - by turning on the `rustls-tls-native-roots` feature in reqwest. (cherry picked from commit 9248dcd)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Certificates in the local trust store are ignored, because reqwest (rustls) is using webpki-roots.
Expected Behavior
Certificates from the local trust store are trusted.
This PR solves this the same way as turborepo - by turning on the
rustls-tls-native-rootsfeature in reqwest.