fix(linter): update lint executor to correctly handle --fix and --quiet#31970
Merged
fix(linter): update lint executor to correctly handle --fix and --quiet#31970
--fix and --quiet#31970Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 1fa7fd6
☁️ Nx Cloud last updated this comment at |
meeroslav
approved these changes
Jul 21, 2025
Contributor
|
Thank you @leosvelperez! |
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 23, 2025
…quiet` (#31970) ## Current Behavior When running ESLint using the `@nx/eslint:lint` executor with `--quiet` and `--fix`, and there are errors, no fix is made, and the task incorrectly succeeds. This is a regression introduced by 9406d2b, which updated the executor to not fix warnings when `--quiet` is used, but the solution was incorrect. ## Expected Behavior When running ESLint using the `@nx/eslint:lint` executor with `--quiet` and `--fix`, and there are errors, fixes should be applied, and the task should succeed if there are no remaining errors. It should not fix warnings. ## Related Issue(s) Fixes #31868 (cherry picked from commit 59496ed)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running ESLint using the
@nx/eslint:lintexecutor with--quietand--fix, and there are errors, no fix is made, and the task incorrectly succeeds.This is a regression introduced by 9406d2b, which updated the executor to not fix warnings when
--quietis used, but the solution was incorrect.Expected Behavior
When running ESLint using the
@nx/eslint:lintexecutor with--quietand--fix, and there are errors, fixes should be applied, and the task should succeed if there are no remaining errors. It should not fix warnings.Related Issue(s)
Fixes #31868