Skip to content

fix(core): lockfile pruning uess project name to identify workspace nodes#31959

Merged
FrozenPandaz merged 1 commit intomasterfrom
fix-prune-lockfile
Jul 17, 2025
Merged

fix(core): lockfile pruning uess project name to identify workspace nodes#31959
FrozenPandaz merged 1 commit intomasterfrom
fix-prune-lockfile

Conversation

@Coly010
Copy link
Copy Markdown
Contributor

@Coly010 Coly010 commented Jul 17, 2025

Current Behavior

The workspace packages logic for pruning lockfile assumes the jsPackageName is the same as the node name.
This is not always the case.

Expected Behavior

Ensure the actual node name is used to reference the node in the project graph

@Coly010 Coly010 requested a review from meeroslav as a code owner July 17, 2025 11:43
@Coly010 Coly010 self-assigned this Jul 17, 2025
@Coly010 Coly010 requested a review from a team as a code owner July 17, 2025 11:43
@Coly010 Coly010 requested a review from xiongemi July 17, 2025 11:43
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 17, 2025 11:55am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jul 17, 2025

View your CI Pipeline Execution ↗ for commit a5032e7

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 14m 36s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 5s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 4s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-17 14:38:15 UTC

@FrozenPandaz FrozenPandaz merged commit b9066a9 into master Jul 17, 2025
7 of 8 checks passed
@FrozenPandaz FrozenPandaz deleted the fix-prune-lockfile branch July 17, 2025 16:42
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants