fix(core): swap from gray -> dark gray for light theme secondary foreground#31901
Merged
FrozenPandaz merged 1 commit intomasterfrom Jul 11, 2025
Merged
fix(core): swap from gray -> dark gray for light theme secondary foreground#31901FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 121f3c8
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Jul 11, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 15, 2025
…ground (#31901) ## Current Behavior Gray for secondary light foreground has low contrast in light themes ## Expected Behavior This pull request includes a small change to the `Theme` implementation in the `packages/nx/src/native/tui/theme.rs` file. The change updates the `secondary_fg` color from `Color::Gray` to `Color::DarkGray` to improve visual contrast. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 89495db)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Gray for secondary light foreground has low contrast in light themes
Expected Behavior
This pull request includes a small change to the
Themeimplementation in thepackages/nx/src/native/tui/theme.rsfile. The change updates thesecondary_fgcolor fromColor::GraytoColor::DarkGrayto improve visual contrast.Related Issue(s)
Fixes #