Skip to content

fix(vite): ensure vue-tsc is used for typecheck of vue projects#31761

Merged
Coly010 merged 1 commit intomasterfrom
31647-use-vue-tsc
Jun 27, 2025
Merged

fix(vite): ensure vue-tsc is used for typecheck of vue projects#31761
Coly010 merged 1 commit intomasterfrom
31647-use-vue-tsc

Conversation

@Coly010
Copy link
Copy Markdown
Contributor

@Coly010 Coly010 commented Jun 27, 2025

Current Behavior

When Vite projects use Vue, the typecheck target still uses the standard TypeScript compiler (tsc) instead of vue-tsc, which is the recommended TypeScript compiler for Vue projects. This can lead to incomplete type checking as
tsc doesn't understand Vue's single-file components (.vue files) and their specific syntax.

Expected Behavior

When a Vite project uses the Vue plugin (vite:vue), the typecheck target should automatically use vue-tsc instead of tsc for type checking. This ensures proper type checking of Vue components and maintains compatibility with
Vue's TypeScript integration. The external dependencies and help metadata are also updated to reflect the use of vue-tsc when appropriate.

Related Issue(s)

Fixes #31647

@Coly010 Coly010 requested a review from a team as a code owner June 27, 2025 13:56
@Coly010 Coly010 requested a review from mandarini June 27, 2025 13:56
@Coly010 Coly010 self-assigned this Jun 27, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 27, 2025 2:08pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jun 27, 2025

View your CI Pipeline Execution ↗ for commit 43de57a.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 31m 7s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 3s View ↗
nx documentation ✅ Succeeded 1m 38s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-27 14:33:42 UTC

@Coly010 Coly010 merged commit 4553748 into master Jun 27, 2025
9 checks passed
@Coly010 Coly010 deleted the 31647-use-vue-tsc branch June 27, 2025 14:46
FrozenPandaz pushed a commit that referenced this pull request Jul 2, 2025
## Current Behavior

When Vite projects use Vue, the typecheck target still uses the standard
TypeScript compiler (tsc) instead of vue-tsc, which is the recommended
TypeScript compiler for Vue projects. This can lead to incomplete type
checking as
tsc doesn't understand Vue's single-file components (.vue files) and
their specific syntax.

 ## Expected Behavior

When a Vite project uses the Vue plugin (vite:vue), the typecheck target
should automatically use vue-tsc instead of tsc for type checking. This
ensures proper type checking of Vue components and maintains
compatibility with
Vue's TypeScript integration. The external dependencies and help
metadata are also updated to reflect the use of vue-tsc when
appropriate.

 ## Related Issue(s)

  Fixes #31647

(cherry picked from commit 4553748)
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vue (@nx/vue@21.2.0) typecheck task does not throw TypeScript error(s)

3 participants