fix(vite): ensure vue-tsc is used for typecheck of vue projects#31761
Merged
fix(vite): ensure vue-tsc is used for typecheck of vue projects#31761
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 43de57a.
☁️ Nx Cloud last updated this comment at |
leosvelperez
approved these changes
Jun 27, 2025
jaysoo
approved these changes
Jun 27, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 2, 2025
## Current Behavior When Vite projects use Vue, the typecheck target still uses the standard TypeScript compiler (tsc) instead of vue-tsc, which is the recommended TypeScript compiler for Vue projects. This can lead to incomplete type checking as tsc doesn't understand Vue's single-file components (.vue files) and their specific syntax. ## Expected Behavior When a Vite project uses the Vue plugin (vite:vue), the typecheck target should automatically use vue-tsc instead of tsc for type checking. This ensures proper type checking of Vue components and maintains compatibility with Vue's TypeScript integration. The external dependencies and help metadata are also updated to reflect the use of vue-tsc when appropriate. ## Related Issue(s) Fixes #31647 (cherry picked from commit 4553748)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When Vite projects use Vue, the typecheck target still uses the standard TypeScript compiler (tsc) instead of vue-tsc, which is the recommended TypeScript compiler for Vue projects. This can lead to incomplete type checking as
tsc doesn't understand Vue's single-file components (.vue files) and their specific syntax.
Expected Behavior
When a Vite project uses the Vue plugin (vite:vue), the typecheck target should automatically use vue-tsc instead of tsc for type checking. This ensures proper type checking of Vue components and maintains compatibility with
Vue's TypeScript integration. The external dependencies and help metadata are also updated to reflect the use of vue-tsc when appropriate.
Related Issue(s)
Fixes #31647