Skip to content

fix(react): do not set styles.tailwind for executor options for projects not using inferred targets#31667

Merged
jaysoo merged 1 commit intomasterfrom
fix/tailwind
Jun 20, 2025
Merged

fix(react): do not set styles.tailwind for executor options for projects not using inferred targets#31667
jaysoo merged 1 commit intomasterfrom
fix/tailwind

Conversation

@jaysoo
Copy link
Copy Markdown
Member

@jaysoo jaysoo commented Jun 20, 2025

This PR fixes an issue when you use React with Webpack/Rspack, and aren't using @nx/webpack/plugin or @nx/rspack/plugin.

Current Behavior

Project configuration contains this for build options:

"styles": ["src/myapp/styles.tailwind"]

Expected Behavior

It shoud be :

"styles": ["src/myapp/styles.css"]

Which is what we actually generate.

@jaysoo jaysoo requested a review from a team as a code owner June 20, 2025 15:19
@jaysoo jaysoo requested a review from ndcunningham June 20, 2025 15:19
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 20, 2025 3:30pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jun 20, 2025

View your CI Pipeline Execution ↗ for commit 16fd5ad.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 21m 57s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 22s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 2s View ↗
nx documentation ✅ Succeeded 2m 45s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-20 15:49:08 UTC

@jaysoo jaysoo merged commit 55251ca into master Jun 20, 2025
8 checks passed
@jaysoo jaysoo deleted the fix/tailwind branch June 20, 2025 19:02
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants