Skip to content

fix(core): use ts-node option from tsconfig files when creating transpiler#31469

Merged
FrozenPandaz merged 1 commit intomasterfrom
core/fix-ts-node-transpiler-options
Jun 5, 2025
Merged

fix(core): use ts-node option from tsconfig files when creating transpiler#31469
FrozenPandaz merged 1 commit intomasterfrom
core/fix-ts-node-transpiler-options

Conversation

@leosvelperez
Copy link
Copy Markdown
Member

Current Behavior

When creating a ts-node transpiler, only compilerOptions are provided. Because we instruct ts-node to skip reading the tsconfig (this was previously done to avoid some edge cases), other options in the tsconfig files are lost (e.g. ts-node specific options).

This was previously reported at #21695 and fixed by #21723, but a rework at a later point caused a regression.

Expected Behavior

When creating a ts-node transpiler, we should provide compilerOptions and the ts-node options.

@leosvelperez leosvelperez self-assigned this Jun 5, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner June 5, 2025 12:19
@leosvelperez leosvelperez requested a review from Cammisuli June 5, 2025 12:19
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 5, 2025 0:54am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jun 5, 2025

View your CI Pipeline Execution ↗ for commit 58cdfeb.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 8m 1s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 21s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 2s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-05 13:25:41 UTC

@FrozenPandaz FrozenPandaz merged commit 9323403 into master Jun 5, 2025
9 of 10 checks passed
@FrozenPandaz FrozenPandaz deleted the core/fix-ts-node-transpiler-options branch June 5, 2025 18:04
FrozenPandaz pushed a commit that referenced this pull request Jun 5, 2025
…nspiler (#31469)

## Current Behavior

When creating a `ts-node` transpiler, only `compilerOptions` are
provided. Because we instruct `ts-node` to skip reading the tsconfig
(this was previously done to avoid some edge cases), other options in
the tsconfig files are lost (e.g. `ts-node` specific options).

This was previously reported at #21695
and fixed by #21723, but a rework at a
later point caused a regression.

## Expected Behavior

When creating a `ts-node` transpiler, we should provide
`compilerOptions` and the `ts-node` options.

(cherry picked from commit 9323403)
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants