Skip to content

fix(release): changelog filtering logic for the project commits#31449

Merged
JamesHenry merged 4 commits intonrwl:masterfrom
LetItRock:fix-changelog-filtering-for-project-commits
Jun 6, 2025
Merged

fix(release): changelog filtering logic for the project commits#31449
JamesHenry merged 4 commits intonrwl:masterfrom
LetItRock:fix-changelog-filtering-for-project-commits

Conversation

@LetItRock
Copy link
Copy Markdown
Contributor

@LetItRock LetItRock commented Jun 4, 2025

Current Behavior

When generating the changelog between the versions for a single project, the changelog CLI tool takes all the commits between the version tags instead of filtering them to that particular project, which results in irrelevant commits included in the changelog.

You can see that behaviour in the Novu monorepo by running this command:

pnpm nx release changelog v3.5.0 --projects=@novu/js --dry-run --from=@novu/js@v3.4.0

Producing this, where for example the first commit (PR 8315) is irrelevant:

+ ## v3.5.0 (2025-06-04)
+
+ ### 🚀 Features
+
+ - **dashboard:** payload schema management UI ([#8315](https://github.com/novuhq/novu/pull/8315))
+ - add build scripts for pnpm ([4c0093dc67](https://github.com/novuhq/novu/commit/4c0093dc67))
+ - **api-service:** adjust locale testing groups to v2 ([#8388](https://github.com/novuhq/novu/pull/8388))
+ - **inbox:** backwards compatible inbox keyless ([b6b42a9f43](https://github.com/novuhq/novu/commit/b6b42a9f43))
+ - **root:** create keyless environment ([#8276](https://github.com/novuhq/novu/pull/8276))
+ - **root:** upgrade nx to v21.0.4 and update nx.json configuration ([#8361](https://github.com/novuhq/novu/pull/8361))
+ - **api-service:** add data attribute filtering for inbox notifications ([#8338](https://github.com/novuhq/novu/pull/8338))
+ - **api-service:** Webhook management ([#8300](https://github.com/novuhq/novu/pull/8300))
+
+ ### 🩹 Fixes
+
+ - **react-native:** update widget_jwt_expiration_time default value to fix session initialized ([#8401](https://github.com/novuhq/novu/pull/8401))
+ - pnpm approved builds ([80df2481f6](https://github.com/novuhq/novu/commit/80df2481f6))
+ - version bump react packages ([62ff7ee154](https://github.com/novuhq/novu/commit/62ff7ee154))
+ - **inbox:** change redirect urls for keyless ([d663dfa5bc](https://github.com/novuhq/novu/commit/d663dfa5bc))
+ - pnpm 10 repo ([65109279ef](https://github.com/novuhq/novu/commit/65109279ef))
+ - **api:** Update mocha configuration to use SWC instead of ts-node ([#8363](https://github.com/novuhq/novu/pull/8363))
+ - novu react rc 4 release ([b737df7335](https://github.com/novuhq/novu/commit/b737df7335))
+ - **api, ws, dashboard, worker:** new release v2.2.0 ([#8334](https://github.com/novuhq/novu/pull/8334))
+
+ ### ❤️ Thank You
+
+ - Dima Grossman @scopsy
+ - George Djabarov @djabarovgeorge
+ - Himanshu Garg @merrcury
+ - Trần Thăng Long @longtranthang
+
  ## v3.4.0 (2025-05-16)

  ### 🚀 Features

Expected Behavior

The changelog commits should be filtered to that specific project.

With the fix, it generates this output instead:

+ ## v3.5.0 (2025-06-04)
+
+ ### 🚀 Features
+
+ - **inbox:** backwards compatible inbox keyless ([b6b42a9f43](https://github.com/novuhq/novu/commit/b6b42a9f43))
+ - **root:** create keyless environment ([#8276](https://github.com/novuhq/novu/pull/8276))
+ - **api-service:** add data attribute filtering for inbox notifications ([#8338](https://github.com/novuhq/novu/pull/8338))
+
+ ### 🩹 Fixes
+
+ - version bump react packages ([62ff7ee154](https://github.com/novuhq/novu/commit/62ff7ee154))
+ - **inbox:** change redirect urls for keyless ([d663dfa5bc](https://github.com/novuhq/novu/commit/d663dfa5bc))
+ - novu react rc 4 release ([b737df7335](https://github.com/novuhq/novu/commit/b737df7335))
+
+ ### ❤️ Thank You
+
+ - Dima Grossman @scopsy
+ - George Djabarov @djabarovgeorge
+
  ## v3.4.0 (2025-05-16)

  ### 🚀 Features

Related Issue(s)

Fixes #

@LetItRock LetItRock requested a review from a team as a code owner June 4, 2025 11:46
@LetItRock LetItRock requested a review from leosvelperez June 4, 2025 11:46
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 6, 2025 9:32am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jun 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9f6f9d4.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 38m View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 17s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded 2m 29s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-06 13:52:25 UTC

JamesHenry
JamesHenry approved these changes Jun 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LetItRock!

@JamesHenry JamesHenry merged commit c5146d1 into nrwl:master Jun 6, 2025
7 checks passed
@JamesHenry JamesHenry changed the title fix(core): changelog filtering logic for the project commits fix(release): changelog filtering logic for the project commits Jun 6, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 12, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@leosvelperez leosvelperez Awaiting requested review from leosvelperez leosvelperez was automatically assigned from nrwl/nx-core-reviewers

+1 more reviewer

@scopsy scopsy scopsy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ndcunningham ndcunningham

@JamesHenry JamesHenry

@AgentEnder AgentEnder

@leosvelperez leosvelperez

@Coly010 Coly010

@xiongemi xiongemi

@barbados-clemens barbados-clemens

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@LetItRock @JamesHenry @scopsy @ndcunningham @AgentEnder @leosvelperez @Coly010 @xiongemi @barbados-clemens