The latest updates on your projects. Learn more about Vercel for Git ↗︎

View your CI Pipeline Execution ↗ for commit 4b49c31.

☁️ Nx Cloud last updated this comment at 2025-06-09 09:15:57 UTC

@claude provide a good description for this PR

Claude finished @Coly010's task in 1m 30s —— View job

PR Description Complete ✅

Here's a comprehensive description for this PR:

Current Behavior

The webpack and rspack plugins for handling non-buildable libraries don't properly process the exports field in package.json. They incorrectly assume libraries have only a single entry point, typically through a barrel file (index.ts).

When a library defines multiple export paths using the exports field (e.g., "./*": "./src/*.ts"), the plugins fail to generate the correct allowlist patterns for webpack externals. This causes build failures when trying to use non-buildable libraries that expose multiple entry points without barrel files.

Expected Behavior

The webpack and rspack plugins should properly parse the exports field from package.json and generate appropriate allowlist patterns for all exported subpaths. This includes:

• Handling wildcard patterns ("./*": "./src/*.ts")
• Processing conditional exports (import/require/development)
• Supporting exact subpath exports ("./utils": "./src/utils.ts")
• Escaping special characters in package names for regex patterns
• Gracefully falling back to reading package.json directly when metadata is unavailable

Changes Made

Core Features Added:

• createAllowlistFromExports(): New function that parses package.json exports and creates allowlist patterns
• Wildcard support: Converts export patterns like "./*" into proper regex patterns
• Conditional export resolution: Handles complex export maps with import/require/development conditions
• Fallback mechanism: Reads package.json directly when project metadata doesn't contain exports

Files Modified:

• packages/webpack/src/plugins/nx-webpack-plugin/lib/utils.ts - Added exports parsing logic
• packages/rspack/src/plugins/utils/get-non-buildable-libs.ts - Same logic for rspack
• Added comprehensive test suites for both packages

Implementation Details:

• Exports are processed with priority: development > import > require > default
• Special characters in package names are properly escaped for regex matching
• Main export (.) is handled separately to avoid duplication
• Graceful error handling when package.json reading fails

Related Issue(s)

Fixes #31419

This description provides the context and technical details needed for reviewers to understand the scope and impact of the changes.

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.