fix(core): ensure nx init implementation for angular correctly resolves @angular/core#31430
Merged
leosvelperez merged 1 commit intomasterfrom Jun 3, 2025
Merged
Conversation
…olves `@angular/core`
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit b985c5a.
☁️ Nx Cloud last updated this comment at |
4 tasks
Coly010
approved these changes
Jun 3, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 3, 2025
…es `@angular/core` (#31430) ## Current Behavior When running `nx init` in an Angular CLI repo located in a directory that has an ancestor directory with an Nx installation, it silently exits when trying to determine the compatibility of the Angular version. The migration is not performed, and no feedback is given to the user. This happens because the current implementation will determine that ancestor directory (outside the workspace root) as the workspace root (when starting the migration, there's no `nx` in the repo). ## Expected Behavior Running `nx init` should work correctly, and proper feedback should be printed to the user if it can't determine the compatibility of the Angular version. It should correctly resolve the `@angular/core` package from the Angular CLI workspace root. ## Related Issue(s) Fixes #31291 (cherry picked from commit cb930d0)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running
nx initin an Angular CLI repo located in a directory that has an ancestor directory with an Nx installation, it silently exits when trying to determine the compatibility of the Angular version. The migration is not performed, and no feedback is given to the user. This happens because the current implementation will determine that ancestor directory (outside the workspace root) as the workspace root (when starting the migration, there's nonxin the repo).Expected Behavior
Running
nx initshould work correctly, and proper feedback should be printed to the user if it can't determine the compatibility of the Angular version. It should correctly resolve the@angular/corepackage from the Angular CLI workspace root.Related Issue(s)
Fixes #31291