fix(angular): install @angular/build when using vitest test runner#31169
Merged
leosvelperez merged 1 commit intomasterfrom May 13, 2025
Merged
fix(angular): install @angular/build when using vitest test runner#31169leosvelperez merged 1 commit intomasterfrom
@angular/build when using vitest test runner#31169leosvelperez merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit ef97855.
☁️ Nx Cloud last updated this comment at |
5f53b8a to
ef97855
Compare
Coly010
approved these changes
May 13, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
May 16, 2025
…31169) ## Current Behavior The application and library generators do not install the `@angular/build` package when using the `vitest` test runner. This can cause resolution issues depending on the package manager because the package is a peer dependency of the `@analogjs/vite-plugin-angular` package. ## Expected Behavior The application and library generators should install the `@angular/build` package when using the `vitest` test runner. ## Related Issue(s) Fixes #30646 (cherry picked from commit e1c0be3)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The application and library generators do not install the
@angular/buildpackage when using thevitesttest runner. This can cause resolution issues depending on the package manager because the package is a peer dependency of the@analogjs/vite-plugin-angularpackage.Expected Behavior
The application and library generators should install the
@angular/buildpackage when using thevitesttest runner.Related Issue(s)
Fixes #30646