fix(core): simplify action dispatch, use mutex locking, and avoid unnecessary clones#31157
Merged
FrozenPandaz merged 1 commit intomasterfrom May 9, 2025
Merged
fix(core): simplify action dispatch, use mutex locking, and avoid unnecessary clones#31157FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
…ement, and avoid unnecessary clones
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 3c1ccb5.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
May 9, 2025
| }); | ||
| if let Some(tx) = &self.action_tx { | ||
| tx.send(action).unwrap_or_else(|e| { | ||
| debug!("Failed to dispatch action: {}", e); |
Contributor
There was a problem hiding this comment.
Food for thought, should this be error!()?
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
parking_lot::mutextask::spawnto dispatch actions. The channel is non-blocking and this is wasted cyclesExpected Behavior
parking_lot::Mutexand removesunwraps()Related Issue(s)
Fixes #