fix(core): do not follow symlinks when creating remote cache tarball#31138
Merged
AgentEnder merged 1 commit intonrwl:masterfrom May 10, 2025
Merged
fix(core): do not follow symlinks when creating remote cache tarball#31138AgentEnder merged 1 commit intonrwl:masterfrom
AgentEnder merged 1 commit intonrwl:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit c572037.
☁️ Nx Cloud last updated this comment at |
ec77bac to
c572037
Compare
Contributor
Author
|
@AgentEnder or @FrozenPandaz I know the code owners already auto-assigned some reviewers, but I think you guys are more up-to-date with this part. Could any of you take a look please? |
Contributor
Author
|
Tested this locally by publishing |
AgentEnder
approved these changes
May 10, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Symlinks in the remote cache tarball are "followed". That modifies the output of Next.js projects using pnpm, causing a restored cache not to work in production.
Expected Behavior
Symlinks are added to the tarball, instead of being followed. I.e. the cache output is not modified.
Related Issue(s)
Should fix #31085.