Skip to content

fix(core): Update React,Vue and Node generators applications for CNW#31059

Merged
jaysoo merged 2 commits intomasterfrom
fix/react-vite-nx-name
May 9, 2025
Merged

fix(core): Update React,Vue and Node generators applications for CNW#31059
jaysoo merged 2 commits intomasterfrom
fix/react-vite-nx-name

Conversation

@ndcunningham
Copy link
Copy Markdown
Contributor

@ndcunningham ndcunningham commented May 5, 2025

Current Behavior

  • Currently, when we create a React, Vue or Node app we add the app name inside package.json under the nx
{
  "name": "@myworkspace/acme",
  "version": "0.0.1",
  "private": true,
  "nx": {
    "name": "acme"
  }
}

  • When we create a publishable library using React/JS generator inside a ts project references workspace the --importPath option.

Expected Behavior

  • Since the original intention is not known we should not automatically add this to the project's package.json
  • importPath option should not be required when using ts project references.

Related Issue(s)

For workspaces that are not using TS project references the result remains unchanged.

Fixes #

@ndcunningham ndcunningham self-assigned this May 5, 2025
@ndcunningham ndcunningham requested review from a team as code owners May 5, 2025 22:38
@ndcunningham ndcunningham requested review from jaysoo and xiongemi May 5, 2025 22:38
@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 8, 2025 3:17pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 5, 2025

View your CI Pipeline Execution ↗ for commit 3c1eb57.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 41m 11s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 17s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 1m 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-08 16:04:12 UTC

@ndcunningham ndcunningham marked this pull request as draft May 5, 2025 22:53
@ndcunningham ndcunningham changed the title fix(core): Update CNW for React,Vue and Node applications to not add nx.name for TS project refs packagejson fix(core): Update React,Vue and Node generators applications for CNW May 6, 2025
@ndcunningham ndcunningham force-pushed the fix/react-vite-nx-name branch from 2fe0400 to 0f2583e Compare May 6, 2025 20:04
@ndcunningham ndcunningham marked this pull request as ready for review May 7, 2025 14:56
…nx.name for TS project refs packagejson

fix(core): Update JS and React library generators to not enforce importPath for publishable libs created inside a TS project references workspace
@ndcunningham ndcunningham force-pushed the fix/react-vite-nx-name branch from 0f2583e to 3c1eb57 Compare May 8, 2025 15:14
@jaysoo jaysoo merged commit 124eba7 into master May 9, 2025
6 checks passed
@jaysoo jaysoo deleted the fix/react-vite-nx-name branch May 9, 2025 12:23
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants