Skip to content

fix(core): tui summary should not show canceled during run-one because tasks are skipped#31014

Merged
AgentEnder merged 1 commit intomasterfrom
fix/tui-summary-shows-canceled
May 2, 2025
Merged

fix(core): tui summary should not show canceled during run-one because tasks are skipped#31014
AgentEnder merged 1 commit intomasterfrom
fix/tui-summary-shows-canceled

Conversation

@AgentEnder
Copy link
Copy Markdown
Member

Current Behavior

If a run-one with the tui enabled fails because of a dependant task failing, and some tasks are skipped, the summary acts as if you canceled the run.
image

Expected Behavior

This behavior is a failure
image

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner May 2, 2025 18:57
@AgentEnder AgentEnder requested a review from leosvelperez May 2, 2025 18:57
@vercel
Copy link
Copy Markdown

vercel Bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 2, 2025 7:10pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 2, 2025

View your CI Pipeline Execution ↗ for commit 9b1cc08.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 5m 26s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 20s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-02 20:17:18 UTC

@AgentEnder AgentEnder force-pushed the fix/tui-summary-shows-canceled branch from 49a0de0 to 9b1cc08 Compare May 2, 2025 19:07
@AgentEnder AgentEnder merged commit 0a4f682 into master May 2, 2025
6 checks passed
@AgentEnder AgentEnder deleted the fix/tui-summary-shows-canceled branch May 2, 2025 20:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants