Skip to content

fix(core): ensure the terminal is restored when cloud exits#31013

Merged
JamesHenry merged 1 commit intomasterfrom
cloud-force-exit-tui-fix
May 2, 2025
Merged

fix(core): ensure the terminal is restored when cloud exits#31013
JamesHenry merged 1 commit intomasterfrom
cloud-force-exit-tui-fix

Conversation

@JamesHenry
Copy link
Copy Markdown
Contributor

Current Behavior

If Nx Cloud calls process.exit(1) while the TUI is running the terminal gets left in a bad state and cloud logs are swallowed.

Expected Behavior

The terminal is restored and cloud logs are printed to the user.

Related Issue(s)

Fixes #

@JamesHenry JamesHenry requested a review from a team as a code owner May 2, 2025 18:36
@JamesHenry JamesHenry requested a review from Cammisuli May 2, 2025 18:36
@vercel
Copy link
Copy Markdown

vercel Bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 2, 2025 6:40pm

@JamesHenry JamesHenry enabled auto-merge (squash) May 2, 2025 18:36
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 2, 2025

View your CI Pipeline Execution ↗ for commit 16afb7a.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 5m 14s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-02 19:29:08 UTC

@JamesHenry JamesHenry merged commit 49e7181 into master May 2, 2025
6 checks passed
@JamesHenry JamesHenry deleted the cloud-force-exit-tui-fix branch May 2, 2025 20:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants