fix(release): only error on missing manifestsToUpdate if a project is being directly processed#31004
Merged
JamesHenry merged 1 commit intomasterfrom May 2, 2025
Merged
Conversation
… being directly processed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 957c9ff.
☁️ Nx Cloud last updated this comment at |
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-31004-957c9ff my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-31004-957c9ff
To request a new release for this pull request, mention someone from the Nx team or the |
FrozenPandaz
approved these changes
May 2, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
If filtering by groups or projects, we still validate that all
manifestRootsToUpdateare valid and in place even for projects which are not captured by those filters (directly and indirectly via dependencies).Expected Behavior
We only validate the
manifestRootsToUpdatethat are applicable to the current versioning run, taking the filters into account.Related Issue(s)
Fixes #