fix(core): improve tui task_list bottom section responsive design#30993
Merged
JamesHenry merged 1 commit intomasterfrom May 2, 2025
Merged
fix(core): improve tui task_list bottom section responsive design#30993JamesHenry merged 1 commit intomasterfrom
JamesHenry merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 1a1a1de.
☁️ Nx Cloud last updated this comment at |
0fe3795 to
ac3fc00
Compare
ac3fc00 to
1a1a1de
Compare
FrozenPandaz
approved these changes
May 2, 2025
| const DEFAULT_MAX_PARALLEL: usize = 0; | ||
|
|
||
| // Constants for layout calculation | ||
| const COLLAPSED_HELP_WIDTH: u16 = 19; // "quit: q help: ?" |
Contributor
There was a problem hiding this comment.
We're going to need a dedicated layout manager for tasks_list.rs soon 😂 I don't know if I'm kidding or not.
Contributor
Author
There was a problem hiding this comment.
I know, I'll never complain about CSS again!
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Depending on the viewport size, or number of open terminal panes, the bottom section of tasks_list can end up visually suboptimal to put it mildly. We also don't have super comprehensive coverage in the visual tests for all the different scenarios that are possible, it's a highly dynamic component.
Expected Behavior
The bottom section of the tasks_list renders as well as can reasonably be expected in almost any scenario and we have increased test coverage of different dynamic scnearios.
Related Issue(s)
Fixes #