fix(core): don't display fork script path in tui#30970
Merged
FrozenPandaz merged 2 commits intomasterfrom May 1, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit e5d4947.
☁️ Nx Cloud last updated this comment at |
JamesHenry
reviewed
May 1, 2025
| execArgv: process.execArgv, | ||
| jsEnv: env, | ||
| quiet: !streamOutput, | ||
| commandLabel: `nx run ${task.id}`, |
Contributor
There was a problem hiding this comment.
This doesn't seem like the right label? We want the underlying tool right? We already have the task id printed on the terminal output pane, we want to know what that task did?
Member
Author
There was a problem hiding this comment.
This fork call is for runs that use executors, not run-commands
FrozenPandaz
approved these changes
May 1, 2025
| @@ -1,5 +1,6 @@ | |||
| use std::collections::HashMap; | |||
| use tracing::trace; | |||
| use watchexec::command; | |||
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The tui displays the path to the fork script in the pty pane
Expected Behavior
The tui displays a command that would be "close enough" to what is being ran in the pty pane
Related Issue(s)
Fixes #