Skip to content

feat(webpack): remove isolatedConfig option for @nx/webpack:webpack#30910

Merged
jaysoo merged 1 commit intomasterfrom
feat/remove-isolated-webpack-config
Apr 29, 2025
Merged

feat(webpack): remove isolatedConfig option for @nx/webpack:webpack#30910
jaysoo merged 1 commit intomasterfrom
feat/remove-isolated-webpack-config

Conversation

@jaysoo
Copy link
Copy Markdown
Member

@jaysoo jaysoo commented Apr 29, 2025

This PR removes the isolatedConfig option that has been deprecated since v17. Back when it was deprecated, we had a migration to remove the option and set webpackConfig with a generate config file that matches the executor's built-in behavior. Now that we're removing the option, a similar migration is added to generate the config files for any projects that skipped the migration the first time.

@jaysoo jaysoo requested review from a team, AgentEnder and FrozenPandaz as code owners April 29, 2025 02:39
@jaysoo jaysoo requested a review from leosvelperez April 29, 2025 02:39
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 29, 2025 0:27am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 29, 2025

View your CI Pipeline Execution ↗ for commit fd6ccc7.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-ci ✅ Succeeded 1m 5s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 21s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-29 13:21:39 UTC

@jaysoo jaysoo force-pushed the feat/remove-isolated-webpack-config branch from 720c304 to fd6ccc7 Compare April 29, 2025 12:15
@jaysoo jaysoo merged commit e1b56f7 into master Apr 29, 2025
6 checks passed
@jaysoo jaysoo deleted the feat/remove-isolated-webpack-config branch April 29, 2025 13:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants