fix(gradle): fix gradle tests#30879
Merged
FrozenPandaz merged 1 commit intomasterfrom May 8, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 722ef22.
☁️ Nx Cloud last updated this comment at |
eff4f26 to
698eb28
Compare
698eb28 to
b782918
Compare
b782918 to
8a5ef9a
Compare
8a5ef9a to
fea829d
Compare
fea829d to
4ac77d8
Compare
4ac77d8 to
539c27f
Compare
539c27f to
dd72c8c
Compare
dd72c8c to
e607ae1
Compare
e607ae1 to
1b8aede
Compare
9c78603 to
96ea274
Compare
FrozenPandaz
approved these changes
May 8, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
currently, because it requires to sign locally, so i thought run command like
:project-graph:publishToMavenLocal -x :project-graph:signNxProjectGraphPluginPluginMarkerMavenPublication -x :project-graph:signPluginMavenPublication -x :project-graph:publishNxProjectGraphPluginPluginMarkerMavenPublicationToMavenLocal -x :project-graph:publishPluginMavenPublicationToMavenLocalwould publish the plugin locally, but it actually does not. it does not throw an error, but does not do anything at all.so for e2e tests, it is actually pulling the latest published gradle plugin from maven rather than test local code, hence the e2e errors.
also, currently project graph build for java version 21, we change it to java 17 to be used by ocean repo.
Expected Behavior
change the command to
./gradlew :project-graph:publishToMavenLocal -PskipSign=trueand not apply signing when skip sign is true, so this should be able to publish plugin to local repository.work with java 17
Related Issue(s)
Fixes #