feat(graph): add undo migration option when one is pending approval#30878
Merged
feat(graph): add undo migration option when one is pending approval#30878
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 52445ab.
☁️ Nx Cloud last updated this comment at |
jaysoo
commented
Apr 25, 2025
| cwd: workspacePath, | ||
| encoding: 'utf-8', | ||
| }); | ||
| // The revision changes after the amend, so we need to update it |
Member
Author
There was a problem hiding this comment.
Previously, the recorded ref in migrations.json were all wrong since they do not include the amended changes to migrations.json. This fixes an existing issue.
ndcunningham
approved these changes
Apr 25, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a button for user to undo a migration that's already been applied and pending approval.
See: https://www.loom.com/share/97286bdc80ea4538af76a914ef8f0f8b
Also, fixes an existing issue where
migrations.jsondid not record the correct git sha for each commit.Current Behavior
When a migration is pending approval, the only option is to accept it.
Expected Behavior
Allow user to undo a migration if they don't want the changes.
Related Issue(s)
Fixes #